Add coverage for ForeignMemoryWriterFactory#11772
Conversation
amarziali
added
type: enhancement
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba64bfbc89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| mock-maker-inline No newline at end of file | |||
There was a problem hiding this comment.
❔ question: Will it impact other mocks from the module too?
There was a problem hiding this comment.
Yes
As an additional note this mockmaker is the default since mockito 5.
There was a problem hiding this comment.
I think that for OperatingSystem/SystemProperties and CO, we should work for a better testability interop (or at least design the class that use it to receive a mock) if we want to avoid mocking statically
* Add coverage for ForeignMemoryWriterFactoryTest * test on 22+
3 participants
What Does This Do
Add coverage for ForeignMemoryWriterFactoryTest. It needs static mocking for the Os/SysProp classes
Coverage is 100% on method, class, branches. 83% on lines
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]